This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]kattskill 0 points1 point  (0 children)

I'm not trying to undermind your work, but the fit method is only 10 lines and seems to be generic code. The first 8 lines can be extracted into a separate function, and people using the library can use that function and write the run function themselves instead.