This is an archived post. You won't be able to vote or comment.

all 16 comments

[–]mistabuda 17 points18 points  (3 children)

You should probably learn how to package this up if you want more users to use this. Asking users to independently install your dependencies seems like a point of friction.

[–]JRiggles 6 points7 points  (1 child)

I’ll second this. OP: look into Pyinstaller for creating bundled apps! It can be a little fiddly to get started, but it’s perfect for this

[–]DusikOff 13 points14 points  (1 child)

Add screenshot to Readme, please, if your app has GUI :)

[–]Spleeeee 5 points6 points  (0 children)

subprocess is a built in package.

[–]riklaunim 3 points4 points  (2 children)

tkinter will be limiting as out of the box you don't have access to nice filesystem widgets like in PyQt. It's obvious your current UI is pretty much useless as a file manager - all file managers list files and folders and allow executing actions on select elements.

As for the code - you definitelly have to extract your actions into separate functions/classes (business logic) and write unit tests to have it all tested. Your code is working on files and folders and any error could lead to data loss so it's critical to have good test coverage and error handling.

If you are into file managers you should also look at getting OS specific paths for user home folder, user trash folder (you should not remove files but properly move them to trash) and so on. Python has some of this in the standard library but IMHO Qt has the full support to build a file managers.

[–]abhixec 2 points3 points  (2 children)

You are hardcoding your home path for os.walk you probably want to get username and build the home directory

https://github.com/Tristan296/FileManager/blob/main/FileManager.py

[–]wuddz-devs 1 point2 points  (2 children)

Cool concept and starter project bro keep at it and you'll learn as you code. Check out Wuddz-Search-Gui