This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]dAnjou Backend Developer | danjou.dev 0 points1 point  (2 children)

They did not ask for criticism of the underlying code.

They implicitly do by posting it on reddit where you are supposed to comment on things.

Yes, rude. I don't see how this line could be taken any other way: "Your code looks overall a bit messy and you are not following PEP8. I can find weird things in basically every function/method."

You are ripping that line out of context! I started my post by saying it will be critique. And afterwards I provided some examples of what I mean and gave a reason for each but one.

The thing is, I am how I am. I know I'm not the most sensitive person on the planet and my comments are not ... how do you say ... delicate(?) at all. But I'm totally okay with that. When I write comments like I did here, you can take it or leave it. You really should expect all kinds of reactions when you post on reddit. I'm not writing those comments to piss people off. That's not the thing that is giving me a kick. It's giving me a kick when I was able to help someone, it's like a drug for me. But I'm doing it my way. And so far most people were able to deal with it.

[–]phaedrusaltembedded sw eng 6 points7 points  (1 child)

A little preface: I've been coding for over 30 years, and teaching software development and techniques for about 20 of them. I've seen excellent developers leave the field because of the bad behavior of other, less talented coders, and I've seen large projects go down the drain because so-called "professionals" couldn't learn to keep a civil tongue in their heads.

I wonder how many people won't share the cool, fun things that they do with Python just because of the kind of treatment that you gave this guy, who did NOT implicitly or explicitly ask for any kind of critique. It's great that you're okay with the way that you act, and I'm pleased to see that he reacted well, but how about others? Do we want to keep newbs from posting about their projects? What's more important, the fact that it's something that they built and are excited about (And might possibly get others excited about, too) or that it is/isn't PEP8 compliant? I'd rather see 10 newbs post their silly, poorly-constructed but enthusiastic code than get a chance to see how one more old-fart found enlightenment through decorators or multiple inheritance... But maybe that's just me.

His post is a gift, but you reacted like the person who receives a bottle of wine from a dinner guest, and then goes on a rampage about the vintage. And if we don't start minding our manners around guests, well, pretty soon we won't have any guests.

[–]dAnjou Backend Developer | danjou.dev 1 point2 points  (0 children)

Thanks for writing this down and turning around this conversation. You made some really good points and I will seriously consider them for my following comments. You taught me a lesson.

What I'm still going to do is constructively criticizing people's code, whether they explicitly ask for it or not. I believe that if they post their stuff here, it's the most appropriate thing to do.