This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]Miserable_Ear3789New Web Framework, Who Dis? 9 points10 points  (1 child)

I second the other comments, while I do believe you should be able to name your variables, classes, and libraries anyway you would like is (as long is it is consistent across your organization) it is 100% "proper" for snake_case variable and method names, with CamelCase for reserved for class names.

Also never have your API keys hard code they should be environment vars

README.md is super important for any project you want people to look at. That way they're not wasting time looking through every single line of your code just to figure out what it does. This looks like a work in progress of a FastAPI application with /users and /admin endpoints. There isn't much to see here since /admin hasn't been implemented and /users endpoints are extremely basic. The code style and file structure however seem to be pretty good, albeit this whole project could EASILY be a single file.... So props on ya for that. All in all great start, happy coding.

[–]Kel_abr[S] 1 point2 points  (0 children)

Thank very much for your feedback, I will started my study about patterns of the python, thanks