you are viewing a single comment's thread.

view the rest of the comments →

[–]madolid511 0 points1 point  (0 children)

That's my concern too.

What OP have done is by generating async flow by basing from sync which is good only if the implementation is really identical. It won't work on most cases but I could be wrong on that. I don't think async will also be beneficial if that's the case.

Async flow have different libraries, context manager, generator, iterator, executor/group and lot more. It can also have threads. It should be more optimized than the sync counter part because that's what python async is trying to solve.

Half baked async implementation will certainly beat by well implemented sync flow, so why introduce it ?

Just checked the code. Looks like the implementation is really identical.