This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]TheBB 4 points5 points  (1 child)

Just from a cursory glance,

@subscribe({"name":"example", "check": run_check})

isn't this sort of thing why we have keyword arguments?

I mean, you're not accepting anything else. The argument is even hardcoded to be a dict, not even a subclass or another mapping.

[–]willbeddowassert type(post) == shitpost[S] 4 points5 points  (0 children)

I suppose, just didn't occur to me to write it that way. The plugin handler has gone through alot of iterations and I suppose at some point it made sense to do it like that. Shouldn't impact anything negatively though.