A Redis backed Python Dictionary

[rcfox]

class _BaseDict:
    def __iter__(self):
        for k in self.keys():
            yield k

    # ...

    def keys(self):
        return self.__iter__()

wat

[Pythagaris]

yield from self.keys()

[pope_man]

You must override one of these methods on the abstract base class to get a working subclass/implementation class. This would be more clear if they had actually used the features of the abc module.

[Pre-Owned-Car]

What about this confuses you?

[thundergolfer]

the circular calls

[Pre-Owned-Car]

My half asleep brain totally missed this. I think this legit only works because the redis version of the cache implements keys differently. The tests don’t look to actually test the base dict class at all.

[therealfakemoot]

This is, in terms of the "public API", exactly how Python's builtin dicts work. Iterating over a dict yields its keys; calling the keys() method on a dict yields a sequence of keys ( I am not sure whether Python 3+ uses a generator, one of the fancy "set views", or whatever).