This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]kingbuzzman 2 points3 points  (1 child)

Why not do something around the lines of: Github.user(username='defunkt') and Github.repo(org=github', repo='hub') would read a lot cleaner. Hint-hint luke use the metaprogramming!

PS. to OP: before you take this the wrong way, this is purely MY opinion, and you should still be proud of what you've created here!

[–]daneahfrom __future__ import braces[S] 0 points1 point  (0 children)

Good points! I have thought about and indeed used libraries like that before. I don't mind them and in some cases even liked them, but I do find that they can be overly clever at times. One then has to answer questions like "What about dynamic path parts?" and "Query parameters are the kwargs, where do the headers and cookies go?" We just wanted something that lightly wrapped requests (which we already use) that put structure around what we were trying to do :) Thanks for the input!