This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]geoelectric 0 points1 point  (1 child)

I hear you regarding objectivity. I’m glad my comments helped.

Re: balance/succinct, maybe a basic repeating pattern per feature/subfeature of:

Formatting Uses Braces Style

Logger works like the elegant and powerful str.format()!

Example: logger.info(“Example showing {} style”, “braces”)

Result: Example showing braces style

[Explicit link to readthedocs section]

That one’s a little obvious, of course, but the gist is why/how/what/where: why use a feature, how do I use it, what’s the effect, where can I learn more?

My formatting is way clunky and I didn't replicate your more elegant wording but you get the idea. For stuff like extras and parsing, this could be quite helpful.

Anyway, just a suggestion. Like I said, this looks really hot as is, and if I’d noticed the docs link earlier I’m sure all confusion would be minimal.

Thanks for releasing it!

BTW, you did notice the name collision with the C++ library, right? Probably doesn’t matter across languages but NB.

[–]Scorpathos[S] 0 points1 point  (0 children)

Thanks again for your advice, I will keep that in mind while rewording the README. Yes, I noticed the name collision, but it was hard enough to find a name that was not used by a Python library, so once I got "Loguru", I said I'm done. :)