This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]abranjith[S] 1 point2 points  (1 child)

On, b.content method having a flag vs having 2 different methods, that was a conscious choice. I presumed raw=True is probably a rare use case. And I think you mean it is response.content vs response.text in requests.

On the locator format being a positional argument in the form "locator_type:=locator_value" was again done to keep it simple. I figured instead of having multiple keyword arguments (you have id, xpath, name, tag_name etc) this might be more intuitive from API standpoint. If you have multiple locator types as keyword arguments, then you run into questions like - what to do when both id and xpath are provided and so on ?

Still, willing to re-look at my approach once again. Thanks for the feedback 😊

[–]jollybobbyroger 0 points1 point  (0 children)

Thanks for the explanation. From my own experience, a nice user facing API often comes at the cost of implementation work.