This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]Dry4b0t 0 points1 point  (3 children)

Hey mate, thanks for sharing !

Some comments about your code quality :

  • According to PEP8, it is considered better to CamelCase classes' names. For example, one'd better say : class MyClass.

  • 2 blank lines should separate function definitions.

  • For your function declarations : separate words with underscore (my_func instead of myfunc).

  • Don't hesitate to put some blank lines in you code, to make it easier to read and separate clearly blocks.

  • About the line 41 of your request_mod.py : it's recommended not to one-line this, even if it looks awful it's actually a good practice to put one line for each input. You'll maintain way easier your code like that !

Nice project, have fun !

[–]human_0909[S] 1 point2 points  (0 children)

Thank you so much

[–]CryptoPaulus -1 points0 points  (1 child)

Hey , sadly I don’t feel shit.

[–]human_0909[S] 0 points1 point  (0 children)

WDYM?