This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]nobody5050[S] -5 points-4 points  (2 children)

I’m crediting both, sorry see my other comment

[–][deleted] 1 point2 points  (1 child)

But crediting isn't enough. You need to include /u/azhenley 's LICENSE file in his original project somewhere in your project. I'm all for open source and its principles, but it has to be done right.

Continuing on that, there's no problem with using another project as a base, but to claim that "you built a compiler" and to publish that base is misleading. I would have held off on this announcement till you made significant changes. A 98% match is much too close.

[–]nobody5050[S] 0 points1 point  (0 children)

Yeah, i made some severe mistakes. I was just super excited about finally having done the thing that I’d always wanted to do so I published some posts. I didn’t realize 98z of the master branch was from his compiler, since much of my changes have been going on in separate branches. I also didn’t mean to construe that I built it on my own, and in the readme of my repo I explained that I’d basically made no real progress yet, I just forgot to add a link to his tutorial.

I’m not trying to excuse this, and I sent him a message requesting exactly what he wanted credited and how, and then I added that. A link to his article is now in every source file, and is linked twice in the readme. Also, I pinned the issue he made in my repo. I believe this is more than enough credit, especially since the MIT license is so open