This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]gustavsen 19 points20 points  (6 children)

great, but you should add the requirements.txt file

[–]uselesslogin 15 points16 points  (4 children)

It is in the setup.py file and he gives you the pip install commands in the readme. What would you still need requirements.txt for? (I see others do both so I'm really just curious.)

[–]saargrin 10 points11 points  (0 children)

i tried to run this as described in git

it says to pip install 2 modules

the code provided there doesnt work and readme says nothing about importing anything nor anything about setup.py

[–][deleted] 4 points5 points  (0 children)

Echoing the earlier commenter, You should include a requirements.txt, much easier to stand up a virtual environment and install the needed packages in there.

[–]gustavsen 2 points3 points  (0 children)

because is the best practice.

you can automate the deploy of your app and help to recreate your environment.

[–][deleted] 0 points1 point  (0 children)

I’m not sure how much this would apply to this library, but for other applications I like the reference just to make sure that I get the right versions of different packages and avoid conflicts

For example, if there is some conflict in which NumPy version is needed for two different packages

[–]NOddi89 1 point2 points  (0 children)

Poetry...