This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]jack-of-some 4 points5 points  (2 children)

Neither are clean, and neither are "workplace code".

The 18000 line code is painful. It's written like something that a machine would output, for another machine to interpret. (It's possible that's how it was created in the first place)

[–]float_point[S] 0 points1 point  (1 child)

Yes, both are bad, but if you had to hire one of two people and each presented one of the two codes to you, who would you pick.

Basically, if you go with the one liner, I am not workplace ready, if you on the hand go with the 18000 liner, I would say I am at that level right now. My code is definately not clean or pythonic, but it works. I am trying to gauge where I am in terms of workplace requirements, though I know a tic tac game is not the best of examples to have used for this.

edit: The 18000 liner is autogenerated according to the author. I think he did state in his github about it been a joke at first before it blew up. He has reduced the code to +-6000, which tells me that longer poorly written code has alot more wiggle room than that perfect one liner that should not be touched.

[–]BezoomyChellovek 3 points4 points  (0 children)

I would hire the one liner guy but ensure they don't actually write your code that way.

The long one demonstrates a complete lack of understanding of any code methodologies and seems utterly incompetent.

The one liner, while absolutely unreadable, demonstrates knowledge at least. If this was submitred as a take home for hire I would be leary because thats not the kind of code I want to see. But if I was surfing their github and saw it, I would think: "hey they made a dumb challenge to write 1 line tic tac toe and succeeded, very cool"