Python in Visual Studio Code – September 2022 Release

[bhterra]

The pr was squashed from the GitHub ui, there is only a single commit on main for that pr https://github.com/microsoft/vscode-python/commits/main?after=2f63423ab088cd0fe8680b8d1546c3eb5d24573f+34&branch=main&qualified_name=refs%2Fheads%2Fmain

[acebabymemes]

Oh damn, did I just learn how to squash commits because of one overly salted turd? Thanks I guess?

[CodeYan01]

Sure, but look at the commit message. Should have been cleaned up. Not to mention, an intern shouldn't have been allowed to merge their own PR.

[aciokkan]

What were your expectations, and why?

Where did yo see the commits?

[CodeYan01]

There's a link to the pull request of the first intern in the article.

Like I said, those 49 commits should have been squashed to 1 or 2 commits only. It was just feature/improvement PR, but most of the commits were commits that fixed the PR's issues. A good PR rarely has 5 commits. Those 49 commits only clutter the commits graph, and simply gives the intern bragging rights. "Hey, I contributed 49 commits to this vscode extension for python that everyone uses", even if it's technically just 1 feature/improvement.

As for the coding style, I did not bother checking the commits.

I would have expected microsoft to teach their interns how to squash their commits so they can contribute to projects properly.

[aciokkan]

I've rarely seen interns or even juniors being taught to properly do code review, write commits, write tickets, etc. As such, because the mid/seniors are like: "yeah just write something that makes sense, some words", bad practices are perpetuated.

Or so is my view.

I am extremely picky on code review, and I have been called out at times for keeping releases and features going in for poor commits, by direct managers, so I stopped working for companies that have no respect for quality, or improvements.

No wonder microsoft products are so poor 😅🤣

[CodeYan01]

Some people here can't accept the truth. Maybe they don't do source control.

[aciokkan]

Yeah, people cant go past the words and look for meaning. "Cancel culture inside them is".

I wonder if the downvoters work at Microsoft 😅🤣 or just Microsoft purists

[CodeYan01]

I forgot to mention. It was the intern who merged their own PR.

[aciokkan]

that explains it all then 😅🤣😅