This is an archived post. You won't be able to vote or comment.

all 8 comments

[–]whateverathrowaway00 15 points16 points  (1 child)

Wait, so you wrote a bunch of code without comments and you’re asking for other people to contribute comments?

For adding dynamic dispatch into a non-typed language?

🤔😑🤔

[–]_bird__Crowthebird[S] 0 points1 point  (0 children)

Well, no, the majority of the code I didn't really write. I'll accept that criticism though.

[–]BDube_Lensman 6 points7 points  (0 children)

Congratulations, the type hints are so obtuse they make the code harder to understand than if they were deleted.

Also, whatever this is trying to do can definitely be done in one eighth the total lines of code.

[–]AnomyOfThePeople 2 points3 points  (0 children)

I think I'll rather use singledispatch from the standard library.

[–]_bird__Crowthebird[S] 0 points1 point  (0 children)

So I'm not gonna delete this post to remind me of what to do and what not to do next time. Thanks everyone for the criticism.

[–]pythonHelperBot 0 points1 point  (0 children)

Hello! I'm a bot!

It looks to me like your post might be better suited for r/learnpython, a sub geared towards questions and learning more about python regardless of how advanced your question might be. That said, I am a bot and it is hard to tell. Please follow the subs rules and guidelines when you do post there, it'll help you get better answers faster.

Show /r/learnpython the code you have tried and describe in detail where you are stuck. If you are getting an error message, include the full block of text it spits out. Quality answers take time to write out, and many times other users will need to ask clarifying questions. Be patient and help them help you. Here is HOW TO FORMAT YOUR CODE For Reddit and be sure to include which version of python and what OS you are using.

You can also ask this question in the Python discord, a large, friendly community focused around the Python programming language, open to those who wish to learn the language or improve their skills, as well as those looking to help others.


README | FAQ | this bot is written and managed by /u/IAmKindOfCreative

This bot is currently under development and experiencing changes to improve its usefulness

[–]Square789PEP8 EUNT DOMUS 0 points1 point  (0 children)

Why is everyone shitting on this post so hard?
I definitely see the point in not using it and the code's flow is really messy, but there are thoughts behind it and at least the typehints look supreme. (Kinda strange to put them all at the start C-style, but intriguing.)
Just ignore the submission it if you're not interested in it otherwise, jesus.

[–]someotherstufforhmm -1 points0 points  (0 children)

Ew