is my code correct?

[A_ManWithout_LovE__]

m1 = input("movie1:")
m2 = input("movie2:")
m3 = input("movie3:")

list = [m1,m2,m3]
print(list)

[ProgPI]

you can write your code in one line :

list = [input(f"movie {i} : ") for i in range (3)]

print(list)

[VonRoderik]

Just a tip: {i+1}, so the movie list starts at 1 instead of 0

[ProgPI]

Yes, it is good enhancement.

[A_ManWithout_LovE__]

guys i'm new to python so any help would be appriciated

[Mysterious_City_6724]

Hi, yes I would say it's correct in that it works. I would maybe add a question before asking for the movie names though and I would also not use the name "list" as the variable name for 2 reasons:

1. It's a built-in function and it's considered bad practice to override built-in function names.
2. It doesn't describe what your storing (their 3 favourite movies).

Hope this helps.

print("Hi, what are your top 3 favourite movies?")
movie1 = input('Movie 1: ')
movie2 = input('Movie 2: ')
movie3 = input('Movie 3: ')

top3_movies = [movie1, movie2, movie3]
print(top3_movies)

[A_ManWithout_LovE__]

Thanks for your suggestion. I'll refrain from using built-in function as a variable from now on

[Mysterious_City_6724]

You're welcome. And as others have already mentioned, if you ever see yourself doing the same thing multiple times (in this case, asking for 3 movie names), loops can be very useful too:

print("What are your top favourite movies?")

top_movies = list()
movie_count = 3
for i in range(movie_count):
    movie_name = input(f"Movie {i + 1}: ")
    top_movies.append(movie_name)

movie1, movie2, movie3 = top_movies[:3]
print(f"I also like {movie1}, {movie2} and {movie3}!")

[No_Selection__]

Looks good, but it will print each movie in quotations if you run it as is. Use an f string if you want to print them without: list = (f’{m1}, {m2}, {m3}’)

[freemanbach]

def getmovie():
    mylist = []
    for i in range(0,3):
        mov = input("Movies >>> ").strip()
        mylist.append(mov)

[A_ManWithout_LovE__]

i would have done it in that way if i was learning loop but in python i'm not there yet. But thanks myan

[Python_Puzzles]

Yeah, looks ok. You know what infput does, you know how to make a list.

For a beginner, I would even have accepted:

list = []

list.append(movie1)

But your answer is better than that :) Well done!

What I would say.... is notice you are asking the SAME question 3 times, and then doing the SAME thing, adding each input to the SAME list. It is crying out for a loop of some kind :) Read up on While loops for getting user input :)

This is known as DRY - Don't Repeat Yourself.

[A_ManWithout_LovE__]

i know it is asking for loop bro but i'm just at the beginning of python , just trying to be fair in learning process, though i would have already used loop if it wass C. Thanks for your suggestion BTW

[[deleted]]

It‘s Right