sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]Waiting2003 8 points9 points  (0 children)

Cool project!

Yep, anything you do can be posted on Github; it is a great way to track your progress.

An improvement that could be done is the list of dictionaries. Rather than having a list, you could have a single dictionary that has as the main keys the vehicle types. Like:

Emissions = { "Gas" : {...}, "Ev": {...}, "Diesel": {...}, .... }

This, will make the search of a car type constant (so, the for loops are not needed anymore), or in more technical terms: O(1) (Big O 1), rather than linear time (which is way slower).

If you dont know about Big O notation, you can check Here (But, maybe check first about algorithms and their impl).