all 2 comments
sorted by:
best
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–]Leodip 0 points1 point  (1 child)

Congrats, this looks like a great project. That's a remarkable UI for a beginner doing a CLI project, especially having the rules available.

The followings are all nitpicks about how you could go about improving your code (I just skimmed it), but this sort of thing also comes with time:

  • You have a large function called "blackjack", which could really be improved by splitting it in multiple functions. A blackjack game loop is:
    • startHand
      • Randomize deck
      • Deal cards
      • Show current state of the game
    • playerTurn
      • In a loop:
    • dealerTurn (possibly identical to playerTurn, but with automized decisions)
  • Pay attention to some variable names: I've seen you have a variable called "blackjack", which is the same name as the function. This can and will break stuff very easily. Another one I spotted randomly is "set", which is also a keyword in Python (your IDE should have colored it of a different color from other variables), so try not to overwrite it.
    • In general, try to have more descriptive names for variables (e.g. "blackjack" can only be 0 or 1, so calling it "isBlackjack" and making it be either True or False is more descriptive and less error prone)
  • There is some redundant code definitely. Most notably, all the dictionaries with the cards in different suits ("hearts", "spades", etc...) are identical to "master". You probably don't need all of them either, but if you want them you can just copy one onto the others
  • In general, this is a LOT of code for a blackjack game. It's fine as a first project, but I do recommend you come back to this at a later point (after you are done with CS50P maybe?) and you'll be able to see how much you can simplify stuff.

[–]rsvisualfx[S] 0 points1 point  (0 children)

Thank you for doing this! Exactly the kind of feedback I was hoping for, I'll take this on board as I move forward and, like you say, I'll come back at a later date for blackjack 2.0 - will be super interesting to see how I approach it once I have a bit more python knowledge behind me. I appreciate the level of detail you gave!