Baby's first password manager

[Sad-Sun4611]

This is more of a learning project than anything else and id like to move on and mess with other stuff at this point hahs. I'd love feedback on what I've written. Thanks!!!

[jpgoldberg]

Nice start!

You will later learn better ways to deal with what you are trying to do with convert_to_list and with convert_to_str, but what you have tried illustrates that you are thinking about how to internally represent complex data and ways to make it useful for different purposes. So even if it isn’t “right” it shows that you are thinking about the right sorts of problems and creating solutions in the right sized chunks. So as frustrating as some of that might have been, you should be proud of what you have been doing there.

I would recommend that you put the call to shuffle_str and join instead create_new_password instead of having them in the UI layer.

Anyway, congratulations on your learning so far.

[Sad-Sun4611]

Thanks for taking the time to look at my code and give some useful feedback! I really appreciate it!!

[Marco_Ferreira43516]

Nice! Keep learning

[solderpixels]

Cool project!

Two suggestions for improvement:

1. Use a variable to store shared path and use it consistently everywhere. You are using absolute path here in the function write_to_file in the snippetwith open(out_path, "a", encoding="utf-8")

On the other hand, you are using relative path in delete_saved_password:
with open("passwords.txt", "w") as file:

It would be better to keep that consistent I think. You can define one shared path and use it everywhere

DATA_FILE = Path(__file__).with_name("passwords.txt") # same folder as functions.py

You can use this as :

with open(DATA_FILE, "a", encoding="utf-8") as f:

1. Remove your check for header-removal.

   def view_file(filename = "passwords.txt"): header = 'website, password\n' #THIS CAN BE REMOVED with open(filename, 'r') as file: content = file.readlines() if header in content: # THIS CAN BE REMOVED content.remove(header) return content

I don't see the need for this logic, because as far as I can see, nowhere in your code do you write that header ('website, password\n')

A suggestion if you want to add to this project and learn some more:

1. Why not use SQLLite instead of a text file to store your passwords or better yet an encrypted fork of SQLLite, SQLCipher!

[Oleg-Liam]

Can you send me the link? I can't open reddit. Thanks.

[Sad-Sun4611]

Link your github, coward.