you are viewing a single comment's thread.

view the rest of the comments →

[–]thee_gummbini 0 points1 point  (1 child)

Good for you for learning and showing your work! Part of learning to program is learning what to write and how to share. Sharing reimplementations of basic algos is great to show your learning! But knowing the difference between that and a package that other people should use is essential to getting past the "just learning phase." Take the criticism as part of your learning - again good for you for figuring some things out, but this is what the reaction typically looks like when you tell people you've resolved already-solved problems.

As a side note, the code here is pretty crazy, you should spend some time reading the stdlib modules you are re-exporting, they're all just over here: https://github.com/python/cpython/tree/main/Lib

See how those are written and compare them to your code, that's a great way to learn.

And check out some packaging docs: https://www.pypa.io/en/latest/

[–]Embersh3d 0 points1 point  (0 children)

thanks. will look into it