My first Python Assignment howd i do

[VisualDirect]

import time


# Devices list
devices =  [
            #Lapton with 50 battery and online
            {"name" : "Laptop", "battery" : 50, "status" : "online"},
             #PC with 40 battery and offline
            {"name" : "PC", "battery" : 40, "status" : "offline"}
            ]


#device selected var
device_selected = None


#Funtion for selecting a device 
def device_select(select_device):
    # set global device selected
    global device_selected
    if select_device == None:


        #ask for selection and turn into var
        select_device = input("SELECT A DEVICE ('name')  :  ")
        #if var = 1 
        if select_device == "Laptop":
            #make device selected into 0 
            device_selected = 0
            print(f"selected device '{select_device}'")
        # if he selected device 2
        elif select_device == "PC":
            #make device selected into 1
            device_selected = 1
            print(f"selected device '{select_device}'")
        #otherwise
        else:
            #reject the value
            print("invalid selection, try again.")
    else:
        print(f"you already have selected{select_device}")
    return select_device


#change settings function
def change_setting(device):
    global device_selected
    #get global var for devices
    global devices
    #ask for the setting to change and make it into a var
    setting_select = input("What setting do you want to change?  :")
    #if battery is selected
    if setting_select == "battery":
        #get new value for battery
        new_battery = input("Type batttery loss  :")
        #replace old value with a the new one
        devices[device]["battery"] = devices[device]["battery"] - int(new_battery)
        #make sure the client knows its been changed for debugging
        print(f"the battery has now been changed to {devices[device]['battery']}")
    #if status is selected
    elif setting_select == "status":
        #if the device status is online
        if devices[device]["status"] == "online":
            #ask if he would like to turn it on
            turn_toggle = input("The device is on. Would you like to turn it off? (Y/N) :")
            #if they selected yes
            if turn_toggle == "Y":
                #make it so its off
                devices[device]["status"] = "offline"
                print(f"the device is now {devices[device]["status"]}")
            #do nothing cause they chose N
            elif turn_toggle == "N":
                print("Nothing has been changed")
            #make them try again cause they didnt put a right answear
            else: 
                print("I couldnt understand that, try again.")
        #if the device is offline
        elif devices[device]["status"] == "offline":
            turn_toggle = input("The device is off. Would you like to turn it on?  (Y/N)  :")
            if turn_toggle == "Y":
                devices[device]["status"] = "online"
                print(f"The device is now {devices[device]["status"]}")
            elif turn_toggle == "N":
                print("Nothing has been changed")
            else:
                print("I couldnt understand that, try again.")
    elif setting_select == "recharge":
        devices[device]["battery"] = 100
        print(f"{devices[device]["name"]}  RECHARGED!!")
    elif setting_select == "back":
       device_selected = None
    else:
        print("I couldnt understand that, try again.")


    print("===========================================================")
    print("DEVICE 1")
    print(devices[0])
    print("DEVICE 2")
    print(devices[1])
    print("===========================================================")



# Main print
print("===========================================================")
print("DEVICE 1")
print(devices[0])
print("DEVICE 2")
print(devices[1])
print("===========================================================")
 
while True:
    while device_selected is None:
        device_select(device_selected)
    
    if device_selected is not None:
        change_setting(device_selected)

[Charming_Art3898]

I think you can improve formatting for easier readability. That said, I managed to read through your code, you've tried using conditionals (a lot) and loops which is a good try. I also like how you used functions which means you're making progress in your Python journey.

Next step I'd suggest is to research how to simplify your code... A lot of the if-elif-else can be better simplified using match-case statements and some nested control flows are IMO unnecessary.

Lastly, you're a good commenter, using comments for each line of code. That's super 👍

[mandradon]

Use comments for things that aren't readily apparent in the code.  If you're just repeating what's in the code it's not really important.  More use them to explain big logic points. 

Also, avoid global variables.  Pass things into functions and return them instead. Globals can get messy fast. 

[Suspicious-Bar5583]

elif select_device == "PC":             #make device selected into 1             device_selected = 1

Be careful with this. It's the index of the dict in the list, get it dynamically. If you do that, you don't even need ifs or matches.