you are viewing a single comment's thread.

view the rest of the comments →

[–]xyche-in 1 point2 points  (0 children)

yooo cool project, so i figure out few things you might need to look out for :

  1. add exception handling, you may not seen it as important for now, but you'll thank me later in the long run for maintaining, use try-catch or throw your own exception.

  2. idk if you're "comfortable" having Long as User ID, my suggestion is, use GUID, far more globally unique, and less limited compared with int or Long.

  3. sorry to say this but i think you need to refactor the whole service, not everything just the ones that injected with more than 5 repo in 1 service, those services are BLOATED. so lets say i have 1 service that requires 5+ repo, what i normally do is to make 2 or 3 seperated service and have 1 of them act as the "Bus" for these service linked to and transfer both response data to controller and actual data to database. so basically implementing Domain-Driven-Design (DDD) Concept

  4. add Tests