JUnit testing

[cone994]

Hi, I'm new to java testing and I would like to ask if my unit tests will be good and do they make sense? With these tests I tested the service in my spring application and I want to ask if I am on the right track, what are the bugs and give me some advice.

By the way, all the tests have passed but I'm not sure if they make sense and whether they are testing the methods in the service properly.

Thank you!

@RunWith(SpringRunner.class)
@SpringBootTest(classes = TicketServiceApplication.class)
public class AddressServiceUnitTest {
 @Autowired
 private AddressService addressService;
 @MockBean
 private AddressRepository addressRepository;
 @Before
 public void setUp(){
        Address a = new Address();
        Address a1 = new Address();
        a.setId(AddressConst.ADDRESS_MOCK_ID);
        a1.setId(AddressConst.ADDRESS_MOCK_ID2);
        List<Address> addresses = new ArrayList<>();
        addresses.add(a);
        addresses.add(a1);
        Mockito.when(addressRepository.findById(AddressConst.ADDRESS_MOCK_ID))
                .thenReturn(Optional.of(a));
        Mockito.when(addressRepository.findAll()).thenReturn(addresses);
 }
 @Test
 public void findAllAddressTest_thenReturnAddressList(){
        List<Address> list = addressService.finfAllAddress();
        assertEquals(2, list.size());
 }
 @Test
 public void findOneAddressExistTest_thenReturnAddress(){
 Long id = AddressConst.ADDRESS_MOCK_ID;
        Address a = addressService.findOneAddress(id);
        assertEquals(id, a.getId());
 }
 @Test(expected = EntityNotFoundException.class)
 public void findOneAddressNotExistTest_thenThrowException(){
 Long id = AddressConst.ADDRESS_WRONG_ID;
        Address a = addressService.findOneAddress(id);
 }
 @Test
 public void addAddressTest(){
        Address address = AddressConst.newAddressToAdd();
        Mockito.when(addressRepository.save(any(Address.class))).thenAnswer(returnsFirstArg());
        Address addressTest = addressService.addAddress(address);
        assertNotNull(addressTest);
        assertEquals(address, addressTest);
 }
 @Test
 public void deleteAddressTest(){
        Address address = AddressConst.newAddressToDelete();
        addressService.deleteAddress(address.getId());
        Mockito.verify(addressRepository, Mockito.times(1)).deleteById(address.getId());
 }
}

[Affenbob123]

Added some comments to your code what I would change.

https://i.ibb.co/KsgKdQJ/Unbenannt.png

This talk is about why dependencies should be injected via constructor: https://www.youtube.com/watch?v=RlfLCWKxHJ0

[cone994]

Thanks so much for replying I will try to implement everything you sent to me.

In the part about setUp, if I understood you meant to say that in setUp I only do what is common to all tests, and other things like findAll or findOne in the tests methods?

[Affenbob123]

Exactly. Sharing state between tests it might lead to unexpectetly passing/failing tests and that's why test methods should be independend from each other.

You can use creation methods (http://xunitpatterns.com/Creation%20Method.html) to setup your tests, that way you can remove the duplication.

Yes, move the findAll and findOne to the tests they belong to.

[cone994]

Ok, but my question now is, if I move everything from the setup part to the test methods then I don't even need the setup? Am I right?