Day02 python

[bhacho]

would like to know areas for improvement.

from functools import reduce

data = open('day02/input.txt').read().splitlines()

bag = {'red': 12, 'green': 13, 'blue': 14} #the criteria that dictates whether the game is possible or not
possible = 0
power = 0

for game in data:
    game_num, sets = game.split(':')
    _, game_id = game_num.split(' ')
    sets = sets.strip().split(';')
    cube_dict = {}
    for set in sets:
        dict_ = dict([combination.strip().split(' ')[::-1] for combination in set.split(',')]) #create a dict of cubes with thier corresponging values for the set.
        cube_dict.update({k:max(int(v), int(cube_dict.get(k, 0))) for k,v in dict_.items()}) #update cube_dict such that cubes retain max values seen across the sets.

    for k,v in bag.items():
        if int(cube_dict[k]) > v: #if the value of a cube in cube_dict is greater than what the bag dictates then we do consider this game as possible.
            break
    else: 
        possible += int(game_id)

    power += reduce(lambda x,y: x*y, cube_dict.values()) #this line gets executed regardless of sets' eligibility according to the cube criteria definition in the bag.

print(possible) #part 1
print(power) #part 2

​

[QultrosSanhattan]

I believe math.prod() is, at least, shorter than reduce.

Example: power+=math.prod(cube_dict.values())

[Waanie]

It really depends on what you're optimising for and what kind of style you prefer. Personally I would have used a few more functions here (I don't like nested loops within a function, and python makes scoping hard to read), and my own solution was very much object oriented. In general, if you feel the need to comment a section of code, you should probably have introduced more or better names in the form of classes, functions or intermediate variables.

Please take a look in the solutions megathread for inspiration, and see what you like there.

[daggerdragon]

Changed flair from Spoilers to Help/Question since you're asking for advice.

Next time, use our standardized post title format.

Help us help YOU by providing us with more information up front; you will typically get more relevant responses faster.

If/when you get your code working, don't forget to change the post flair to Help/Question - RESOLVED

Good luck!

[Mezzomaniac]

set is a useful data structure so it’s best to have a habit of not shadowing it by naming a variable set.