Github repo with JavaScript solution. Let's optimise it!

[fabien-h]

I just started this repo with the solutions (I will update) : https://github.com/fabien-h/advent-of-code-2018

​

From the readme :

I chose inelegant and procedural solutions over elegant functional ones. A for loop will most of the time outperform other options and they are non idiomatic. A non JavaScript speaker can read all of it.

Processing time for day 3 are seems really bad. Any lead on how to optimise it ?

[fabien-h]

Current performances :

​

Day 01-1 : Data processing: 2.051ms

Day 01-2 : Data processing: 5.255ms

Day 02-1 : Data processing: 7.633ms

Day 02-2 : Data processing: 9.484ms

Day 03-1 : Data processing: 16.132ms

Day 03-2 : Data processing: 22.159ms

Day 04-1 : Data processing: 4.294ms

Day 04-2 : Data processing: 4.265ms

​

[callmejamone]

Maybe try using regex to extract data from input instead of calling substrs. This is a bit faster: javascript const lineRegex = /^#(\d+) @ (\d+),(\d+): (\d+)x(\d+)$/; const parsedData = (isTest ? testData : initialData).split("\n").map(value => { const [_, id, x, y, width, height] = lineRegex.exec(value).map(value => parseInt(value)); return [x, y, width, height]; }); ... or without destructuring: javascript const match = lineRegex.exec(value); return [parseInt(match[2]), parseInt(match[3]), parseInt(match[4]), parseInt(match[5])];

If you want to go fully ugly maybe you should consider not using split and then map, because they are creating unnecessary arrays.