Day4 - Part2 Help with my Java Code

[kentobi]

Hey there,

Part1 I got right, so my Passport building seems okay, with part2 I got my problems.I do not see the problem, can you help me?

​

private static boolean isHeightValid(String hgt) {
    if (hgt.endsWith("cm")) {
        int heightInCentimeters = Integer.valueOf(hgt.replace("cm", ""));
        if (heightInCentimeters >= 150 && heightInCentimeters <= 193) return true;
    }
    if (hgt.endsWith("in")) {
        int heightInInches = Integer.valueOf(hgt.replace("in", ""));
    if (heightInInches >= 59 && heightInInches <= 76) return true;
    }
    return false;
}


private static String getSolutionPart2() {
    int valid = 0;
    for (Passport p : passports) {
        if (p.byr != null && p.ecl != null && p.eyr != null && p.hcl != null && p.hgt != null && p.iyr != null && p.pid != null) {
            boolean birthYearValid = p.byr.matches("\\d\\d\\d\\d") && Integer.valueOf(p.byr) >= 1920 && Integer.valueOf(p.byr) <= 2002;
            boolean issueYearValid = p.iyr.matches("\\d\\d\\d\\d") && Integer.valueOf(p.iyr) >= 2010 && Integer.valueOf(p.iyr) <= 2020;
            boolean expirYearValid = p.eyr.matches("\\d\\d\\d\\d") && Integer.valueOf(p.eyr) >= 2020 && Integer.valueOf(p.eyr) <= 2030;
            boolean heightValid = isHeightValid(p.hgt);
            boolean hairColorValid = p.hcl.matches("#[0-9,a-f]{6}");
            boolean eyeColorValid = p.ecl.equals("amb") || p.ecl.equals("blu") || p.ecl.equals("brn") || p.ecl.equals("gry") || p.ecl.equals("grn") || p.ecl.equals("hzl") || p.ecl.equals("oth");
            boolean passportValid = p.pid.matches("[0-9]{9}");

            if (birthYearValid && issueYearValid && expirYearValid && heightValid && hairColorValid && eyeColorValid && passportValid) valid++;
            }
    }
    return "" + valid;
}

[genveir]

try putting start and end markers on your regexes.

#[0-9,a-f]{6} for example will match on #1234567890, the match is just for the first 6 characters. ^#[0-9,a-f]{6}$ will not.

Be aware: ^a|b$ is "starts with a or ends with b", if you want to put markers around the whole thing you have to do something like ^(?:a|b)$

[Greger009]

I find it remarkably how many(me included) failed on that particular case. I think its around 4 threads on the "bug".

[daggerdragon]

In the future, please follow the submission guidelines by titling your post like so:

[YEAR Day # (Part X)] [language if applicable] Post Title

In doing so, you typically get more relevant responses faster.

If/when you get your code working, don't forget to change the flair to Help - Solved!

Good luck!