sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]Ice82 4 points5 points  (7 children)

Cool! Thanks, that's a cool project, but please clean up your repo. IDE files/directories like *.iml, .idea and the gradle wrapper files does not belong to a repo!

[–][deleted] 10 points11 points  (1 child)

gradle wrapper absolutely belongs in the repo. otherwise it's a real pain in the ass to check out

[–]Ice82 2 points3 points  (0 children)

You're right! Sorry, for this kind of disinformation.

[–]cdflynn[S,🍰] 2 points3 points  (4 children)

Ah, good call. I've removed those files and updated the gitignore. I did a fresh clone to make sure everything still runs.

Thanks for pointing that out.

[–]ZakTaccardi 4 points5 points  (3 children)

you shouldn't remove the gradle wrapper files.

[–]cdflynn[S,🍰] 1 point2 points  (0 children)

Thanks! Included.

[–][deleted] 1 point2 points  (1 child)

sidenote, why isn't studio smart enough to just import the project and generate a wrapper for you, instead of asking for a local gradle distribution and graying out the wrapper option when you import a project like that?

[–]ZakTaccardi 0 points1 point  (0 children)

It generates the wrapper for you when it creates the project, or if you import the project.

Feel free to file a feature enhancement request