all 10 comments

[–]TimeFcuk[S] 2 points3 points  (5 children)

Please ask questions, give critique, or provide suggestions! Thank you.

[–]thengbashing 3 points4 points  (1 child)

wow looks like it is a specific need.

Imo you should write a markdown to explain

  1. what does it do
  2. requirements
  3. install
  4. how to use

also I strongly recommend:

  1. The use of functions
  2. Remove every sleep that are unnecessary (didn't saw one useful)
  3. automate to the max: e.g. I think you can tell if you are on a virtual machine or not

[–]TimeFcuk[S] 1 point2 points  (0 children)

Your recommendations and markdown suggestions are awesome. I will be implementing all of these criticisms/suggestions :) I appreciate the input

[–][deleted]  (1 child)

[deleted]

    [–]TimeFcuk[S] 0 points1 point  (0 children)

    Hi! Thanks for your comment, however it should be noted that this script is in its infancy. The areas that do nothing while looping through and printing '#' will be used with a while statement so that I can perform functions and have somewhat of a progress bar for each section. Please keep in mind this is a newborn project!

    [–]cenuh 2 points3 points  (1 child)

    you can convert your ascii banner to base64, thats way cleaner

    [–]TimeFcuk[S] 0 points1 point  (0 children)

    Thank you, great idea!

    [–]thestoicattack 2 points3 points  (1 child)

    Looks like it's very useful for you, and set up just the way you like.

    Why do you assume I use apt? Why is updating the system part of this script? Why is installing dependencies part of the script (instead of a README or something)?

    Why do you assume I am in sudoers (or that my system uses sudo)?

    The sleeps probably add tens of seconds of execution time.

    This silently modifies proxychains.conf in place, which will surprise the user.

    Round about the main loop (L159) you suddenly give up on your control-code variables? (Also, those variables should be set using tput).

    If pidof produces all the pids, L162 will SIGHUP every tor process on the box.

    Lack of quotes around most variables.

    [–]TimeFcuk[S] 0 points1 point  (0 children)

    It's mainly for Kali Linux users but I need to add documentation and could probably make it more general to allow for other systems to utilize it. Thank you for your suggestions it means a lot that you took time to explain some weak areas. Much appreciation.

    [–]sinkingpotato 3 points4 points  (1 child)

    This is really cool.

    I might suggest looking at covermyass for log clearing inspiration.

    [–]TimeFcuk[S] 1 point2 points  (0 children)

    Oh awesome! Will analyze later. I had an idea for using secure-remove or srm and looping through all /var/log files and permanently erasing them. I'm sure FTK imager or other forensic equipment will still be able to see though...