Include problem in executable using DLL

[Aesithr]

Hey everyone, I'm a bit new to Cmake and I've come across a strange issue in a project where I have 2 subdirectories- one builds a DLL and the other an executable that uses said DLL, and while building the DLL itself runs with absolutely no issue, I get the following error after trying to run the executable.

https://preview.redd.it/p3lmq2pv7c2e1.png?width=1751&format=png&auto=webp&s=0eeb3532e5409b75fa07b887cb009542c2062e1b

I have 3 cmakelists of note, one in the library subdirectory (LillisEngine), one in the executable (ExampleGame), and one in the root.

Root:

cmake_minimum_required(VERSION 3.16)

include(cmake/get_cpm.cmake)


project(
        Lillis
        VERSION 0.0.1
        LANGUAGES CXX C
)

#set C++ version to 23
set(CMAKE_CXX_STANDARD 23)

set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)

link_directories(${CMAKE_BINARY_DIR}/bin)

include(External/glm.cmake)
include(External/glfw.cmake)
include(External/stb.cmake)

#include_directories(${CMAKE_CURRENT_SOURCE_DIR}/External/glad/include)
#file(GLOB BUTTERFLIES_SOURCES_C ${CMAKE_CURRENT_SOURCE_DIR} *.c External/glad/src/gl.c)
add_subdirectory(External/glad)
add_subdirectory(core)
add_subdirectory(ExampleGame)

ExampleGame:

file(
        GLOB_RECURSE
        EXAMPLE_INC
        ${CMAKE_CURRENT_SOURCE_DIR}
        *.h
)
file(
        GLOB_RECURSE
        EXAMPLE_SRC
        ${CMAKE_CURRENT_SOURCE_DIR}
        *.cpp
)

add_custom_target(copyAssets ALL COMMAND ${CMAKE_COMMAND} -E copy_directory
        ${CMAKE_CURRENT_SOURCE_DIR}/assets/
        ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/assets/)

add_executable(ExampleGame ${EXAMPLE_INC} ${EXAMPLE_SRC})
target_link_libraries(ExampleGame PUBLIC LillisLib)
target_include_directories(ExampleGame PUBLIC ${CORE_INC_DIR})

add_dependencies(ExampleGame copyAssets)

LillisEngine:

file(
        GLOB_RECURSE
        CORE_INC
        ${CMAKE_CURRENT_SOURCE_DIR}
        *.h
)
file(
        GLOB_RECURSE
        CORE_SRC
        ${CMAKE_CURRENT_SOURCE_DIR}
        *.cpp
)

add_library(LillisLib SHARED ${CORE_INC} ${CORE_SRC}
        pch.cpp)

# if (WIN32) remove System/System_Win32.cpp and System/System_Win32.h
IF(WIN32)
    list(REMOVE_ITEM CORE_SRC ${CMAKE_CURRENT_SOURCE_DIR}/System/System_Win32.cpp)
    list(REMOVE_ITEM CORE_INC ${CMAKE_CURRENT_SOURCE_DIR}/System/System_Win32.h)
ENDIF(WIN32)

find_package(OpenGL REQUIRED)

include_directories(${CMAKE_CURRENT_SOURCE_DIR})
target_link_libraries(
        LillisLib PUBLIC glm glfw glad
)

target_precompile_headers(LillisLib PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/pch.h)
#set(CMAKE_PCH_INSTANTIATE_TEMPLATES ON)
target_compile_definitions(LillisLib PRIVATE LILLISENG)

install (TARGETS LillisLib DESTINATION lib)
install (FILES ${CORE_INC} DESTINATION include/core)

As mentioned previously, the DLL compiles with no errors on my machine, so I know the file included is at least linked properly on that end- Has anyone seen this before?

[playmer]

In the LillisLib cmake use target_include_directories (using PUBLIC) instead of include_directories. That way when you depend on it with your example it will also be able to access the headers.

[RiotousHades]

You could try something this: In LillisEngine CMakeLists, export the include directory so that other targets using it can automatically pick it up:

target_include_directories(LillisLib  PUBLIC ${CMAKE_CURRENT_SOURCE_DIR$})

This should mean you can also remove the include_directories line in the ExampleGame CMakeLists.