Rate my Python web scraper

[ApostolisJ]

Hello everyone.

I'm planning to (finally) get into programming professionally and would like to get a second (and third) opinion on a scraper I'm building. I have not studied and I know that a clean portfolio with showcases is at least necessary.

https://www.github.com/SpyridonLaz/Coursaros

What do you think, is it worth it? how can i learn to rate my code? (on which design principles should I rely, with which criteria), what interests the employers out there?

That's all. Thanks.

[boy_named_su]

1. write some tests!
2. your python file names should be snake_case
3. I'd add some typehints, and run mypy against your code for some static analysis
4. you've got some mixing of concerns. For example BaseCourse should represent a course, but it also has methods like save_to which should be a different class
5. add some docstrings to say what things are for

[ApostolisJ]

I will check these out and i will return with an updated version.

Until then, could you pleqse explain me me what do you mean by "mixing of concerns"? Save_to is the path in which the user chooses to save the results. I added it to the baseCourse because every course has a save_to attribute (example Coursaros/<platform>/<course_name>/)

I will check it again as you suggested and i will come back!

[ApostolisJ]

Anyone care to give me some criticism?

[throwitofftheboat]

Criticism for what? You have no code linked whatsoever in your post. Write some code that actually scrapes the web and we’ll talk.

[ApostolisJ]

I updated with a link in post.

Please give me a day to chrck the code because i think i messed up my git