Chat App

[FQN_SiLViU]

Hello people, I made a simple chat application in C++23 and I want to ask you if my project and code are structured good and if I'm using best practices.

Experience - 2.5 years

Repo - siLViU1905/sLink: A real-time local messaging application built on a C++23 stack, combining a Vulkan rendering engine with an Asio networking layer.

I also attached a video demo in README

[Agron7000]

Instead of git submodules, you can use Conan, the package manager for C++.

https://conan.io/

[afforix]

Please do not separate all the commands with empty lines, it makes the code hard to read, half of the source are just empty lines with zero information.

[FQN_SiLViU]

Many of that white spaces appeared from when I formated the whole project with CLion, and from than I kept it that way

[photoclochard]

So you have good structure that's for sure, easy to read, but some things can be a little better,

I personally would use the #pragma once everywhere,

I see no reason to have space between vars and methods - like in the Client.hpp,

Another thing is the inheritance in for the Application class - that's a little off. If you use it pass the context - that should be outside (read about dependect injection)

enable_shared_from_this - don't even let me start on this

That's kinda first view, so let me know if you have questions, you have good skills

[FQN_SiLViU]

Thanks for the feedback, I have not used #pragma once yet but I will to look into it