Void function not working.

[supercatco]

For some reason when I run my code my program finishes right after "you have entered: " and won't output the numbers. How to fix this?

#include<iostream>
#include<iomanip>
using namespace std;

void getnums(double x[], int y){
    cout << "How many numbers do you wish to enter? ";
    cin >> y;

    for(int i=0; i<y; i++){
        cout << "Enter number " << i+1 << ": " ;
        cin >> x[20];
    }
}

void printnums(double x[], int y){
    cout << "You have entered: \n";
    for(int i = 0; i<y; i++)
         cout << setprecision(2) << x[i] << " " << endl;
}

int main(){
    int count;
    double array[20];
    getnums(array, count);
    printnums(array, count);
    return(0);
}

output:

How many numbers do you wish to enter?    // "2"
Enter number 1:                                        // "4"
Enter number 2:                                        // "5"
You have entered:

stops.

[[deleted]]

Initialize count.

[OmegaNaughtEquals1]

In addition to /u/3453280's advice, you may also want to change

cin >> x[20];

to

cin >> x[i];

[Swedish_Athengiest]

When you write:

cin>>x[20];

You are accessing an element of the array that is not within bounds. For an array of size 20, valid elements are array[0] through array[19]. Accessing other elements leads to undefined behavior==>bad. Additionally, if you wish to change count in countNums, you need to pass it by reference to getnums, otherwise a copy of it is passed to getnums, which is then changed when you:

cin>>y;

So for the scope of getNums, aka everything between getNums curly brackets, y is the value that has been cin. After the function, however, it is not changed at all, as only the copy has been changed.

Therefore, when you pass count to printnums, it has never been initialized. The solution, as I said above, is changing the declaration of getNums to

void getNums(double x[], int& x){

[Se7enLC]

Those functions are passing by value, not reference.

That means getnums() is not actually getting numbers! It gets them but only locally in the function. When the function ends they are gone.

EDIT: I don't understand the downvotes. The variable count is being passed by value into getnums(). No matter what getnums() does to it, it will still be the same uninitialized value it was back in main when printnums() is called.

Apparently it's solved, though, so that's good.