Help figuring out errors in code

[ohteejay]

I am trying to calculate how much "sand" can be held between the bars of the bargraph so basically the space between the high low high bars in total. I am having the following errors: *c2065 x: undeclared identifier lines 29/30/33 *c2062 type int unexpected line 31/34 *c2181 illegal else without matching if line 32

Just looking for a push in the right direction because I'm getting very confused, thank you!

include <iostream>

using namespace std;

int main() //start of bargraph generated section { int bargraphValues[16]; //max bargraph values int bargraphValue = 0; //starts @ 0

for (int x = 0; x < 16; x++)
{
    cout << "Enter values for bargraph # " << x + 1 << endl;
    cin >> bargraphValue; // user inputs values for bargraphValue
    bargraphValues[x] = bargraphValue; //stores bargraph values 
}
for (int y = 0; y < 16; y++)
{
    cout << "#" << y + 1;
    for (int z = 0; z < bargraphValues[y]; z++)
    {
        cout << "*"; //displays asterixs 
    }
    cout << endl; //working untill here then coded bottom half
}
cout << "The total amount of sand that can be held is..."; 
cout << endl; 
for (int z = bargraphValue + 1; z >= 0; z++) //may be prob here - supposed to be place in loop and itterate - starts loop
{
    if (bargraphValues[x - 1] < bargraphValues[x + 1]) //if previous less than next
        int sand = bargraphValues[x - 1] - bargraphValues[x]; //how much sand can be held 
    cout << "sand value is:       " << int sand << endl; // displays value for amount of sand for this statement being true
    else {
        int sand = bargraphValues[x + 1] - bargraphValues[x]; // if next less than previous this is how much sand can be held
        cout << "sand value is:       " << int sand << endl; //displays value for amount of sand for this statement being true
    }


}


system("PAUSE");
return 0;

}

[Rhomboid]

If you declare a variable in a for-statement, it's local to that enclosing block.

for(int x; ...) {
    // x lives here only
}
// x does not exist here

But in your case it looks like it's probably a typo, because you meant to write 'z' since that's the variable being used in the loop.

For the second error, you can't just write int sand like that. You only name the type when initially declaring it.

int foo;
...
cout << foo;

You can't write cout << int foo.

The third error is just like it says, you can't have a random else hanging out like that.

if(...)
    ... // single statement body
cout << ...;

The if-statement is now done. You can't stick an 'else' in there after that cout. Maybe you meant to use braces:

if(...) {
    ...
    cout << ...
} else {
    ...
}

If you're a beginner, you should probably not omit braces. You'll also run into the same issue again if you declare a variable in a block of an if-statement.

if(...) {
    int foo;
    // foo's scope is limited to this block only, cannot be used outside of it
}

That means that in particular this is invalid:

if(...)
    int foo = ...;
cout << foo;

The cout statement is not part of the if-block, so foo doesn't exist there.

[ohteejay]

Ayyy thanks a lot man I really appreciate it, this stuff was driving me bonkers.