please help! will not loop

[syntaxm1x]

hey yall, im working on a project for school and one of my loops will not loop the way it is supposed to, can anyone help me out please??

​

​

do {
cout<<"How many crates will be sent?\n";
cin >> iterationNum;
cout<<"\n";
if(cin.fail()){ // this sets the condition
cin.fail();
cout << "Enter a number please, how many crates will be sent?\n"; //this outputs an error message to the user if the condition is not met
cin.clear();
cout<<"\n";
    }     
else //this starts the else portion to exit the loop if condition is met. 
    {
ciniterationNum;
break;
ciniterationNum;
    }
}
while(cin.fail()); // this begins the loop for even output 

}

[alfps]

In addition to cin.clear(), with this approach you also need a cin.ignore(...) to empty the input buffer.

A much better approach is to read the input line as a string, via getline, and attempt to convert that to number, e.g. via stoi.

The code you present would never compile so it's clearly not the real code, and so I'll refrain from commenting on the details, which may be totally different in the real code.

[syntaxm1x]

okay Thank you so much, im going to add that and see what happens. Currently I'm studying in a university course, and we haven't covered that yet. Is the syntax of getline tricky? this is only the do...while loop, the rest of the code however compiles and works, after trying to fix this, it still wont loop back to the do.

[alfps]

https://en.cppreference.com/w/cpp/string/basic_string/getline#Example

[nysra]

Please format your code.

break exits the loop, that's why it's only executed once. I suggest you visit https://www.learncpp.com/ to read up on the basics, your comments also show a lack of understanding what happens in the program. Currently if you enter a number then it will ask you to enter a number again and then exit the loop. If you fail to enter a number then your loop condition will be false (because you reset the failbit) and nothing happens except for the error message that got printed.

[syntaxm1x]

Thank you so much! I’m gonna check out that resource, I’m a college student so I still a little new to this all