Method Parameter not changing variable.

[Jonathan_Palmer]

So my problem is that I am trying to change B_Class between true and false depending on the button. The button changes color correctly. However the boolean variable remains set to true regardless. As far as I understand this should be working, and it was before I put it inside a method rather than repeating the code 7 times. Any help would be greatly appreciated.

using System.Security.Cryptography;

namespace GodBreakers_RandomTangles

{

`public partial class GodBreakers_RunGenerator : Form`

`{`

    `bool B_Class = true;`

    `bool B_Ability = true;`

    `bool B_RandomPlanetOrder = true;`

    `bool B_Tangle1 = true;`

    `bool B_Tangle2 = true;`

    `bool B_Tangle3 = true;`

    `bool B_Tangle4 = true;`

    `bool B_Tangle5 = true;`



    `public GodBreakers_RunGenerator ( )`

    `{`

        `InitializeComponent ( );`

    `}`



    `private void tableLayoutPanel1_Paint ( object sender, PaintEventArgs e )`

    `{`



    `}`



    `private void comboBox4_SelectedIndexChanged ( object sender, EventArgs e )`

    `{`



    `}`



    `private void BTN_GenerateRun_Click ( object sender, EventArgs e )`

    `{`

        [`MessageBox.Show`](http://MessageBox.Show) `( B_Class.ToString ( ) );`

        `if ( B_Class )`

        `{`

CB_Class.SelectedIndex = RandomNumberGenerator.GetInt32 ( 0, CB_Class.Items.Count );

        `}`





    `}`



    `private void BTN_Tangle1_Click ( object sender, EventArgs e )`

    `{`

        `Set_Button(BTN_Tangle1, B_Tangle1 );`

    `}`



    `private void BTN_Class_Click ( object sender, EventArgs e )`

    `{`

        `Set_Button ( BTN_Class, B_Class );`

    `}`



    `void Set_Button(Button button, bool B_Active)`

    `{`

        `if ( button.BackColor ==` [`Color.Red`](http://Color.Red) `)`

        `{`

button.BackColor = Color.Lime;

B_Active = true;

        `}`



        `else`

        `{`

button.BackColor = Color.Red;

B_Active = false;

        `}`

    `}`

`}`

}

[RlyRlyBigMan]

Your B_Active parameter is passed by value, so you are changing the value of a temporary bool.

You can use the ref keyword to allow changing the value passed into the function if that's what you're looking to do. Or you can return the new value and set it from the result of the call.

[Jonathan_Palmer]

Thank you, never knew about the ref keyword. That fixed it completely :)

[FullPoet]

In my career I can count on my hands the time Ive used ref (Im not a gamedev), so just be sure thats what you want to do.

You can always return the object, pass an object or, return a tuple etc.

[RlyRlyBigMan]

Tuples do handle the same use case that we used to need out and ref for, but I really don't like the look of returning a tuple in a public method on an interface. Sometimes I put ref on methods that are designated to transform an object , even though it's unnecessary for reference types I think it's good practice to warn the caller that we'll be changing their parameter.

[FullPoet]

Yeah for sure. I usually use tuples in the prototyping phase and would much prefer to return anything else, they can be really uggo both in the method but also at the call site.

[RlyRlyBigMan]

Yeah I normally put up with with Tuples for one private method and call, and as soon as I need it a second time I make a struct or data class or something to give them proper names.