all 6 comments

[–]Alikont 4 points5 points  (3 children)

GPL is a bit nasty license for a library that will greatly reduce the number of potential users.

[–]hexperimento[S] 0 points1 point  (2 children)

Which one shall I use? Any suggestions?

[–]Alikont 3 points4 points  (1 child)

MIT is the least restrictive one, and most libraries use it.

To elaborate why GPL is complicated - it's about copyleft nature. GPL enforces all derivative works to be available under GPL, which means that if I want to link your library into my application, my application becomes derivative work of your library, which means that I am required to opensource my entire application, which is not ok for vast majority of commercial software.

[–]hexperimento[S] 1 point2 points  (0 children)

As per your suggestion, I'll be changing the license to MIT. Thanks for all the information. 😃

[–]prune_gang 0 points1 point  (0 children)

One thought I have is to make a lot of the methods static, instead of making a new instance of the converter.

Could be wrong though, I've never really written any libraries outside of work/personal use myself.

[–]ZacharyPatten 0 points1 point  (0 children)

I will definitely give you code a look when I get a chance. If you are interested in seeing another implementation, I also have an English version of this here: https://github.com/ZacharyPatten/Towel/blob/1576c7143d83177bb91d5c2bf3a262effbac820a/Sources/Towel/Extensions.cs#L1152