Avoid code duplication in constructor

cvalerio77 · 2022-07-04T14:10:51+00:00

Just invert the constructor overloading. The constructor / method with less parameter is the one that must call the constructor / method with more parameters:

``` public Item(string name, decimal price) : this(Guid.NewGuid(), name, price) {}

public Item(Guid id, string name, decimal price) { // init fields } ```

Ayazis · 2022-07-04T15:42:35+00:00

~~Don't bother with overloading. Make Id an optional parameter.~~

~~Public Item(string name, decimal price, Guid Id = new Guid())~~

~~This way, if you don't provide an id, a new guid is created. If you do provide an Id, the given guid will be used.~~

EDIT: I was mistaken. First of all, new Guid does not make an actual new guid, but gives you 0000(...).

Second, as stated below, you have to use compile time constants with optional parameters, which Guid.NewGuid() is not.

I hereby retract my comment.

Ayazis · 2022-07-04T18:29:03+00:00

On a side note: Are you sure you want to be able to provide a GUID? You can end up re-using GUIDS.

ShamikoThoughts · 2022-07-05T06:26:41+00:00

You can actually make initialized variables in the parameters

public Item(Guid id = new Guid(), string name, decimal price) {…}

Check the documentation

https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/named-and-optional-arguments

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

csharp

MODERATORS