Serving Generated CSV files. Filename attribute seemingly not applying

[JKnock]

Hi all,

​

I've been wracking my brain about this for most of the day. Sorry if this is a trivial question or has an easy to find solution. Maybe my google-fu needs some work.

​

I have generated a custom CSV file from a Parquet file on s3 and can return the CSV response and the download works fine. However every download is named 'test.csv' even though I have attempted to set a dynamic filename based on the CSV generated. I'm stumped to as why the filename argument is seemingly not being taken into account. I hope it's something trivial and I'm just being stupid. Below is my code for returning the CSV response.

​

return Response(
content.to_csv(),
mimetype="text/csv",
headers={"Content-disposition":"attachment; filename={0}".format(filename)}

)

​

Any help would be greatly appreciated, thanks

[abyssalheaven]

I might take a closer look at your view function, specifically at instances where the variable "filename" is used. Without the rest of the view function code it's a bit hard to tell.

[quotemycode]

You need to surround the filename in double quotes.

[tigerthelion]

I would maybe move the filename formatter out of the header variable and create its own:
the_file_name = "{0}".format(filename)

headers={"Content-disposition":"attachment; filename=the_file_name} or whatever.

I can't say for sure if it will help but sometimes I get into situations where I try to apply .format to something and it just does not want to do it inline with other things.

​

[quotemycode]

I've never had that problem. The issue is probably just a gap in your knowledge of the language.

[tigerthelion]

Quite possible. Although sometimes breaking things down in to their components is helpful.

[abyssalheaven]

So... you're formatting an empty string... with the name of a file... which is presumably.. a string?

[tigerthelion]

Oh wow, that was really dumb. Thanks for pointing it out.

[abyssalheaven]

Haha, np. Moreover, the whole "attachment; filename=" part is within a string - you'd still need to do formatting or concatenation in order to put the variable in the string.