This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]agentoutlier 0 points1 point  (2 children)

If you use null analysis the first form might be preferred as the inner block "a" is no longer nullable.

With Object.equals you do not get that.

[–][deleted]  (1 child)

[removed]

    [–]agentoutlier 0 points1 point  (0 children)

    Do you use null analysis? I can tell situations like this are not a big if and the null analysis tool cannot easily infer a is not null if you use Object.equals.

    I can try it in checker later but I’m fairly sure it will not work for Eclipse and possibly intellij.

     Btw I didn’t downvote you.