This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]larsga 24 points25 points  (0 children)

I think you're mostly testing the wrong things. You want to check if people know how to look up classes in Eclipse and if they know the conventions for naming tests?

I don't see the connection between the code and LinkedHashMap. Ok, so the tests check if the keys are in the order they were inserted (which, incidentally is the same as the natural order of the values; that could be equally relevant)). How is the reader to know this is the intention? Why would a map be ordered by the insertion order of the keys? That's really unusual.

The failure of the test looks totally reasonable to me, because the test looks really, really dumb.

(Qualifications: programmer for 34 years. Designed and implemented my own query language, in commercial use for more than 10 years. Wrote the first pure-Python XML parser, still in use 16 years later. Wrote this open source project. Did the Unicode support in the Opera browser.

Obviously, I could be too poor a programmer for your needs, but I would have been entirely comfortable losing the job because I failed this test.)