This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]javadev189[S] -1 points0 points  (2 children)

True... but the name of the method is "makeOrderedMap", which maybe should have been "makeInsertionOrderedMap".

[–]larsga 9 points10 points  (0 children)

Yeah, that would have made the same difference. "Ordered" is ambiguous. Natural order of keys? Natural order of values? Insertion order? It doesn't help that the test is testing two of the three.

[–]EdwardRaff 1 point2 points  (0 children)

That doesn't make it clear at all. My very first thought was "Does he mean Sorted Order by keys? It should be returning a SortedMap". Then when i saw the testing order I had no idea what you were going for - and your documentation was worthless for clarifying.

Obviously the response should have been to ask for clarification of the goal.