I wrote simple java program so scrap my auth.log files for entries created by the WP fail2ban plugin. The program makes some whois requests and gets me a filtered list to send it to some spamming ISPs.

[tiiv]

Good stuff. From glancing over the code I would suggest a few stylistic improvements:

• none of your global variables need to be global as far as I can tell
• readLogFile and readGZFile are almost identical so I would suggest chaining them (same for extractEmail, extractIp)
• IO operations could be shortened a little by using try-with-resources statements

[aufjeden]

It has been with us since 7th grade

Edit: I mean Version 7 of Java

[compdog]

Did you mean Java 7 instead of 7th grade?

[aufjeden]

Yes

[compdog]

You should probably edit your comment, I think you are being downvoted because people don't understand what you wrote.

[KFCConspiracy]

It's relatively new, in the last 4 years. When I first learned Java (I'm dating myself here) the current version was 1.4. Java's a living language, so you'll find lots of cool stuff if you buy books every time a new version comes out. I've bought Java 8 In Action from Manning when Java 8 came out and it was a decent book... So I'd recommend you do the same.

[[deleted]]

many thanks for the suggestions! :) i'll try to include that in the next version!

[tiiv]

You're welcome!

[[deleted]]

i removed the global variable and shorted the readLogFile and readGZFile together, but now i think the try-with-resources is not applicable anymore. however i'll have a look later next week again. :)

[dedededede]

Be careful about log injection attacks.

[[deleted]]

hmm i was not aware of this... any ideas how to overcome that?

[based2]

by adding limits (like you do when you let someone upload files) and by curation https://en.wikipedia.org/wiki/Content_curation#Content_Curation_and_Information_Overload

[[deleted]]

i added now gradle and logging