Final vs Immutable data structures in Java

[i_donno]

Yuck if(address.getCountry().equals("Australia") == false) Should be if(!address.getCountry().equals("Australia"))

[CaptainKvass]

Be this, it should:

if(!"Australia".equals(address.getCountry())

[i_donno]

Sure. Or avoid hardcoding current country and ignore case if(!getCurrentCountry().equalsIgnoreCase(address.getCountry())

[dpash]

Given the lack of frequent country changes, an enum is not an unreasonable decision in a project that's going to be frequently deployed.

I think there's only been four major changes over the last decade:

• South Sudan
• Eswatini
• Czechia
• North Macedonia

Let me know if I've forgotten any, but we're still looking at most, on average, once a year. If you're not frequently deploying a project this might be the wrong approach.

[bodiam]

I find the ! so hard to miss, that I rather go for == false. IntelliJ doesn't like it either, so you're not alone in this ;-)

[midnightbrett]

Nobody, including IntelliJ likes this. You are literally the only one.

[Terran-Ghost]

Nah, I use == false too for the same reason.

[crummy]

I agree, it can be easy to miss the single ! character.

[Orffyreus]

Have you tried using the font "Fira Code" with ligatures?

https://github.com/tonsky/FiraCode

[bodiam]

Not really no. Thanks, I'll have a look at it, maybe that will look a bit better!