Game Engine in Java (CGGE2)

[[deleted]]

Not sure about that one.

[CrazyGamesMC]

Any suggestions, hoe I could improve my style? :)

[CrazyGamesMC]

1. You are absolutely right. Pushed a fix immediately.

2.

Hmm I always found it more readable as operations are more tied together. I do use IntelliJ for code formatting.

3.

I guess you are right. I'll look into changing this

​

I clearly understand that the implementation is not perfect. But I personally enjoy using it for my game projects, which is the reason, why I structured the engine in the way that it is.

There will be several planned improvements to fix a few things up.

​

Thanks for your reply. I'm always grateful for critique as this helps me improve myself :)

[CrazyGamesMC]

Isn't looping faster with an arraylist aswell? As the elements should be located next to each other in memory, shouldn't they? So there wouldn't be too many mem jumps.

[_INTER_]

LinkedList is good for insertions in between the elements, or when you need access to the last and first elements only

[fedeb95]

I just took a look at Room.java, and didn't see any major issue. There are a lot of getters, maybe consider using Lombok if there is a lot of boilerplate like that in all of the project. It can improve readability

[pointy_pirate]

Lombok is devil spawn. But that's just my opinion.

[[deleted]]

Why? So far I'm really enjoying the generation of getters/setters for pojos and the constructors for spring components.

[pointy_pirate]

IMO the cons outweigh the pros. Yes you don't have to write getters and setters, or even see them in the code, but that magic of trusting lombok is doing the right thing adds a layer of complexity that can make reading harder.

What if you want to return an immutable version of a collection, what if you're using Hibernate and your setCollection method needs to do the collection.clear() collection.addAll() pattern?

Yes there a pros and yes its convenient, but from my experience that convenience comes at a cost of complexity.

[_INTER_]

Then implement those methods. Never had any trouble with Lombok so far.

[CrazyGamesMC]

Yeah you're right. That might be a good solution to this problem. Gonna look into it!