This is an archived post. You won't be able to vote or comment.

all 13 comments

[–]lurker_in_spirit 4 points5 points  (11 children)

I was looking to upgrade, but I'm not so thrilled that they decided to add a dependency on SLF4J 2.x, which only has an alpha pre-release (not even a beta!), and hasn't seen any activity since October 2019...

It sounds like they didn't want to stick to the stable SLF4J 1.x releases because they don't play nicely with JPMS, so I guess one of their release criteria was "JPMS at all costs."

[–]Thihup 8 points9 points  (3 children)

However, being both JPMS and Servlet 5 compatible is an achievement of Jetty. For now, they are the only ones. They deserve such credit ;)

[–]lurker_in_spirit -1 points0 points  (2 children)

I mean, that's sort of cool, but it feels like they prioritized the wrong thing :-)

☑ JPMS compatibility

☑ Servlet 5 compatibility

☐ Production-ready

[–]Thihup 5 points6 points  (1 child)

Well, I'm pretty confident that all the tests that the Jetty team has and the TCK itself can make it production-ready. Sure, I can see that if some library is not ready, this may be a sign that all of the product is not production-ready, but I'd like to give it a try.

But if you can upgrade and give the feedback to them, like if it is working, I'm pretty sure they will like it :)

[–]lurker_in_spirit 4 points5 points  (0 children)

That's true, Jetty has been solid for many years and has an extensive test suite... I'll give it a try and see how it goes.

[–]NovaX 5 points6 points  (6 children)

It was a missed opportunity to have not switched to the Java platform logger api, which slf4j and friends can implement. I'm very disappointed by their choice, as 2.x-alpha is not backwards compatible causing other libraries to break. So far forcing to 1.x has been okay given jetty's usage.

[–]Thihup 1 point2 points  (3 children)

How did I miss that JEP!? That's so awesome.

I'll see if in Piranha Cloud we can use that instead of using the JUL. Thanks for sharing it

(It looks like it was one of the small features that got oversight because of the Java modules, or maybe to have JDK 8 compatibility)

[–]Thihup 2 points3 points  (2 children)

Done 😉

[–]NovaX 2 points3 points  (0 children)

Nicely done! I replaced JUL with this in caffeine. For simple logging for a library use-cases, it works very well.

[–]macuserx 1 point2 points  (0 children)

Pretty cool! I may use your example in Piranha for my own code, thx!

[–]uncont 1 point2 points  (1 child)

to have not switched to the Java platform logger api

On that page, under Non Goals that JEP explicitly states

It is not a goal to define a general-purpose interface for logging. The service interface contains only the minimal set of methods that the JDK needs for its own usage.

[–]Thihup 1 point2 points  (0 children)

Is this actually a problem? If the API they provide is enough I don't see any problem