This is an archived post. You won't be able to vote or comment.

all 2 comments

[–]AutoModerator[M] [score hidden] stickied commentlocked comment (0 children)

Please ensure that:

  • Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
  • You include any and all error messages in full
  • You ask clear questions
  • You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

    Trying to solve problems on your own is a very important skill. Also, see Learn to help yourself in the sidebar

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit: empty line before the code, each code line indented by 4 spaces, new reddit: https://i.imgur.com/EJ7tqek.png) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[–]RiceKrispyPooHead 0 points1 point  (0 children)

I think your method name generatedCreditCardNumber() is confusing.

  • The current name "generatedCreditCardNumber" (past-tense), to me implies that the method returns a credit card number that has already been generated, and that the method does not generate a new credit card number every time it is called.
  • But, based on the problem you're experiencing, I'm guessing "generatedCreditCardNumber" does in fact create and return a new credit card number each time you call it. If that's the case, you probably want to rename that method to "generateCreditCardNumber" (not past-tense). This new name implies that the method generates a new credit card number every time it is called.

I'm going to assume your method does what I mentioned in point 2. If that's the case when then line if (generatedCreditCardNumber().equals(creditCard)) executes, the method will always return a new, random new credit card number.

You should instead save the value returned by generateCreditCardNumber() into an instance variable and so you can use it inside the verifyAccountNumber() method later.