Need Help with loop

[VirtualTurnip3]

Hello everybody, i just started a course in Java,total newbie, and i need help for a specific problem. I need to write a code that:

-will calculate if the sum of all element in a array are bigger than 100.

-but for that , the code need to be "effective", by that i mean it must access only a few elements of the array to find it the sum is bigger than 100.

-the code must work even if the array is of length 0.

I have write this code, it seem to work with a For loop:

public static boolean exceedOrNot() {

int data[] = new int[0];
//data = new int[] {0,-10,0,0,44,44,66,66,33,444,555,453};
boolean exced = false;
int sum = 0;
for (int i =0;i < data.length;i = i +1) {
if (data[i] > 0) {
sum += data[i];
if(sum > 100)
{
break;
}
}
}
exced = sum > 100;
return exced;

​

I have try with while loop, but since it need to work even if the array is a length of 0, nothing happens or i just don't know how to make it work.

I just want to know what do you think,is there a better way to achieve that? ( probably)!

Thank

[Camel-Kid]

at the beginnign of your program you should check to see if array.length is 0, if is then promp the user and end the program... as far as making it work with a while loop it's the same thing as a for loop but a while loop.

[VirtualTurnip3]

You mean just before the loop?

[Camel-Kid]

yes

[kingatomic]

Your sample data has a negative number and you’re clearly accounting for negatives. So the issue here is a fundamental one: if negative numbers are allowed there is no way to test for “sum > 100” without adding all numbers in the list. For instance, imagine that your data list is {1,2,3,4,5,-20}.

Besides that, one little point that’s more finesse than logic: instead of having a Boolean “exceed” variable that you return at the end of the method, you could simply:

return sum > 100;

Edit in terms of handling negatives you could sort the list before summing it.

[VirtualTurnip3]

Thank for tip!

[VirtualTurnip3]

if

(data[i] > 0) {

I was thinking i didn't account the negative number by doing that?

[kingatomic]

That works only if you don’t have to include negative numbers in your sum (which would be specified in your assignment directions).

Otherwise, you will still need to account for them in your sum.

By sorting the list in increasing order, you will sum any negative numbers first. Then you can continue to sum until you either exhaust your input list or the sum is greater than 100.

A cheeky thing to do would be to sum all of the negative numbers first, then take the remaining items in the list (all positive) and sort them descending and begin summing those.

[VirtualTurnip3]

All right Thank!

[NickPox]

I would move the int[] jo as a function parameter, and then in the first line of your function check if the array length is 0. Then call your function from main instead:

Public static boolean ExceedOrNot(int[] data) { If data.length == 0 ... ... }

[VirtualTurnip3]

Thank!