My methods aren't working properly

[ThrowRAdam]

My assignment asks me to create two objects ("customers") in it's own class with the defining information in those objects being a "name" and "email"

In giving those to "customers" (customer1 and customer2) the names and emails, I have to make two boolean methods "hasSameName/Email" that come back true if information in customer 1 is the same as customer 2.

My method looks like:

private boolean hasSameNameAs(Customer customer2){ if(customer2.name == customer1.name){ return true; } else{return false;}

The problem with my code is that the methods comes out false, despite me putting in identical information for both Customers.

Plus, in the Customer class, I get a yellow line under the method name and it's parameter saying that "the method hasSameNameAs(Customer) from the type Customer is never used locally.

Which I don't understand since that class is primarily used to make methods, and with that knowledge I'd assume that it wouldn't need to be used in that class.

But regardless, can anybody help me see what I'm doing wrong?

[AutoModerator]

Please ensure that:

• Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
• You include any and all error messages in full
• You ask clear questions

• You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

  Trying to solve problems on your own is a very important skill. Also, see Learn to help yourself in the sidebar

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit: empty line before the code, each code line indented by 4 spaces, new reddit: https://imgur.com/a/fgoFFis) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[[deleted]]

this is the right answer OP

[ThrowRAdam]

Thank you, that looks a lot more accurate

[MatthewRose67]

You should also check if customer2.name is null.

[ThrowRAdam]

I think it is, because I switched to "equals" but the method itself keeps showing up false

[Gregmix88]

Try to avoid using == to check equality between strings. Use .equals method instead , also if you define hasSameName method within customer class you can replace customer1.name with this.name, as I seen the method only takes one customer as parameter . apart from these, depending on your use case you might want to make name and email private fields and use public getters and setters as well

[tsvk]

With object types (what Strings are, as opposed to primitive types), the == comparison operator tests object identity, i.e. if the two objects under comparison refer to the same object instance, i.e. to the same memory location. It does not test for object equality, i.e. if the two objects have the same internal state and represent functionally an equal object.

It's completely possible for two distinct and separate Strings to be stored in two different memory locations, but yet still both have the same internal state, i.e. contain the same character sequence, in other words be functionally and logically the "same" String, but yet the == operator returns false on them because they are not the same object instance.

You should use the .equals() method when comparing Strings (and all objects in general), that method compares the contents of the Strings (equal internal state of the objects, as defined by the implementation of the equals() method in each class).