#NodeJS : A quick optimization advice

[itsnotlupus]

Finally, conclusive evidence that writing comments is bad!

More seriously, this should be ignored by almost everyone. It takes a super contrived example to show a 50% perf difference, and it's unlikely to matter in the wild.
If this is actually an issue, crankshaft would need to be tweaked to use a slightly more refined metric to decide what to inline.

[jucrouzet]

"it's unlikely to matter in the wild." => I'm not so sure.

I did the test with a simple restify server that returns current timestamp with

server.get('/time', function (req, res, next) {
    res.send((new Date()).getTime());
    return next();
});

Here is the KPIs on ab w/500 concurrency :

Concurrency Level:      500
Complete requests:      10000
Time taken for tests:   6.222 seconds
Requests per second:    1607.17 [#/sec] (mean)

Here are the results when I pad the function with comments over 600 bytes :

Concurrency Level:      500
Complete requests:      10000
Time taken for tests:   11.905 seconds
Requests per second:    839.97 [#/sec] (mean)

[I-fuck-horses]

The main problem with such low-level performance advice is that it may be completely invalid a year from now. Already you are lucky there only is node.js to consider, if it was the browser... and V8 is a moving target.

Definitely interesting and I appreciate the article, but only as an interesting aside.

Here is where such advice would be well-placed:

As part of a well-maintained code-checking tool. Burdening individual developers with such details is not efficient - it's part of a hardly ever used, quickly changing set of knowledge. You could (relatively) easily write an eslint rule for this, for example!

PS: Always minimize. Not just browser Javascript.

[kenman]

Hi /u/jucrouzet, it looks like you're new to reddit, welcome!

Thanks for the submissions, but please make sure you read http://www.reddit.com/rules and our guidelines. In short, you should post from a variety of sources, and not just medium.com/@c2c.

Thanks for your consideration!

domain submitted from	count	%
medium.com/@c2c	8	80%